BUG: Concatenation warning still appears with sort=False #27702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return res.reindex(self.index, copy=False) | ||
| else: | ||
| return concat(frames, axis=1, join=how, verify_integrity=True) | ||
| return concat( |
There was a problem hiding this comment.
I suspect that this branch is under-tested... Could you update your new test to also assert the result of the concat operation?
pandas/tests/frame/test_join.py
Outdated
| @@ -24,6 +24,14 @@ def right(): | |||
| return DataFrame({"b": [300, 100, 200]}, index=[3, 1, 2]) | |||
|
|
|||
|
|
|||
| @pytest.fixture(params=[True, False, None]) | |||
There was a problem hiding this comment.
Perhaps just define this as a pytest.mark.parametrize on the test itself? Since we only use it once that's a bit clearer.
added 5 commits
August 1, 2019 16:48
TomAugspurger
approved these changes
Aug 2, 2019
Co-Authored-By: Tom Augspurger <[email protected]>
|
thanks @ncernek |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 4, 2019
…s with sort=False
jorisvandenbossche
pushed a commit
that referenced
this pull request
Aug 5, 2019
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff